Make configuration a top-level option #2375
Merged
+83
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR moves the
--configurationoption to the top-level, making it possible to do stuff likephinx --configuration phinx.yml status, whereas right now--configurationmust follow the command (e.g.phinx status --configuration phinx.yml). This should make it drastically simpler to run multiple different phinx commands (migrate, rollback, status in my case) where in the terminal, I can hit up, delete the command, and then type a new command, without needing to left key past--configuration phinx.yml.As this is a top-level command, I've added support for it to
initcommand as well since that was the only command that currently didn't use it, though thepathargument still takes precedence